Re: [PR] [VL] tools/workload/tpch: Close sql files to avoid resources leak [incubator-gluten]

["xinghuayu007 (via GitHub)" <gi...@apache.org>]

xinghuayu007 commented on code in PR #10785:
URL: https://github.com/apache/incubator-gluten/pull/10785#discussion_r2415381520


##########
tools/workload/tpch/run_tpch/tpch_parquet.scala:
##########
@@ -77,11 +70,24 @@ val sorted = fileLists.sortBy {
      }}
 
 // Main program to run TPC-H testing
+val resultMap = mutable.Map[String, Double]()
 for (t <- sorted) {
-  println(t)
-  val fileContents = Source.fromFile(t).getLines.filter(!_.startsWith("--")).mkString(" ")
-  println(fileContents)
-  time{spark.sql(fileContents).collectAsList()}
-  //spark.sql(fileContents).explain
+  val fileContents = {

Review Comment:
   Done. I mean to print the final results for statistics without any middle results. Maybe the middle results is important for  other situations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org