[GitHub] [incubator-uniffle] lifeSo commented on pull request #1078: [#1062] fix(tez): Fix to use TezIdHelper to getTaskAttemptId instead of default IdHelper.

["lifeSo (via GitHub)" <gi...@apache.org>]

lifeSo commented on PR #1078:
URL: https://github.com/apache/incubator-uniffle/pull/1078#issuecomment-1689328154

   > @lifeSo But I doubt that how to generate the block id.
   > 
   > > I does not review here carefully before. There are little different with my initial version.
   > 
   > https://github.com/apache/incubator-uniffle/blob/1e4804b944bd91887748fc0ad2771825752f3a28/client-tez/src/main/java/org/apache/tez/common/RssTezUtils.java#L157
   > 
   > 
   > Here I don't know why we use nextSeqNo.
   
   One Shuffle Write task may write multi  block, so this block is differ from blockId and each block is differ from nextSeqNo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org