You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by William A Rowe Jr <wr...@rowe-clan.net> on 2018/04/18 16:48:44 UTC

/scheme/i sensitivity? (was: svn commit: r1829430 - /httpd/httpd/patches/2.4.x/core-check_errorlog_dir_syslog.patch)

On Wed, Apr 18, 2018 at 11:36 AM, Jim Riggs <ji...@riggs.me> wrote:
> Fair enough. I'm fine standardizing either way. strn?cmp() is probably more "correct". As it stands, though, the check in core is not actually checking everything that log.c will handle.

There are a number of places where we have "scheme:resource"-style
resources throughout httpd. Especially mod_ssl.

Do we want to make a group commitment to strn?casecmp() all of
these cases in any 2.next/3.0 release?

AW: /scheme/i sensitivity? (was: svn commit: r1829430 - /httpd/httpd/patches/2.4.x/core-check_errorlog_dir_syslog.patch)

Posted by Plüm, Rüdiger, Vodafone Group <ru...@vodafone.com>.

> -----Ursprüngliche Nachricht-----
> Von: William A Rowe Jr [mailto:wrowe@rowe-clan.net]
> Gesendet: Mittwoch, 18. April 2018 18:49
> An: httpd <de...@httpd.apache.org>
> Betreff: /scheme/i sensitivity? (was: svn commit: r1829430 -
> /httpd/httpd/patches/2.4.x/core-check_errorlog_dir_syslog.patch)
> 
> On Wed, Apr 18, 2018 at 11:36 AM, Jim Riggs <ji...@riggs.me> wrote:
> > Fair enough. I'm fine standardizing either way. strn?cmp() is probably
> more "correct". As it stands, though, the check in core is not actually
> checking everything that log.c will handle.
> 
> There are a number of places where we have "scheme:resource"-style
> resources throughout httpd. Especially mod_ssl.
> 
> Do we want to make a group commitment to strn?casecmp() all of
> these cases in any 2.next/3.0 release?

strn?casecmp() on the scheme part? I guess this would make sense.

Regards

Rüdiger