You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/13 13:43:07 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…

nsivabalan commented on code in PR #5703:
URL: https://github.com/apache/hudi/pull/5703#discussion_r969646947


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1118,7 +1118,7 @@ protected Map<String, Option<HoodiePendingRollbackInfo>> getPendingRollbackInfos
       HoodieRollbackPlan rollbackPlan;
       try {
         rollbackPlan = RollbackUtils.getRollbackPlan(metaClient, rollbackInstant);
-      } catch (IOException e) {
+      } catch (Exception e) {

Review Comment:
   @danny0405 : may I know why this fix was required? If we had exception like timeout or something else, probably we should not process it. we have the code within catch block only to handle corrupt files. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org