You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/12/20 06:13:00 UTC

[GitHub] [echarts] pissang opened a new pull request #16246: fix(bar): avoid creating subpaths in the sausage shape

pissang opened a new pull request #16246:
URL: https://github.com/apache/echarts/pull/16246


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   This PR optimize the sausage shape by avoiding creating subpaths with `moveTo` command. It can improve the visual effect of morphing significantly.
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Subpaths may have matching issue when doing one-one morphing.
   
   ![before](https://user-images.githubusercontent.com/841551/146720092-50686a69-5860-4b7d-b6ae-232ef6f63f24.gif)
   
   ### After: How is it fixed in this PR?
   
   Vertices are matched perfectly.
   
   ![morph](https://user-images.githubusercontent.com/841551/146720155-8ad7aca0-111f-4055-8620-84d4a3d7841d.gif)
   
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #16246: fix(bar): avoid creating subpaths in the sausage shape

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16246:
URL: https://github.com/apache/echarts/pull/16246#issuecomment-997627067


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #16246: fix(bar): avoid creating subpaths in the sausage shape

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #16246:
URL: https://github.com/apache/echarts/pull/16246


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #16246: fix(bar): avoid creating subpaths in the sausage shape

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16246:
URL: https://github.com/apache/echarts/pull/16246#issuecomment-997628592


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org