You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/23 00:40:14 UTC

[kudu-CR](branch-1.2.x) KUDU-1812. address comments on 1179bbdb

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5572

Change subject: KUDU-1812. address comments on 1179bbdb
......................................................................

KUDU-1812. address comments on 1179bbdb

Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Reviewed-on: http://gerrit.cloudera.org:8080/5566
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit f3447a104fd5b6ca71122914838ea5f7d73c8efe)
---
M src/kudu/client/client.h
M src/kudu/client/write_op.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/partial_row.h
M src/kudu/common/partition-test.cc
M src/kudu/common/types-test.cc
M src/kudu/tools/tool_main.cc
M src/kudu/util/logging.h
8 files changed, 35 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5572/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>

[kudu-CR](branch-1.2.x) KUDU-1812. address comments on 1179bbdb

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-1812. address comments on 1179bbdb
......................................................................


KUDU-1812. address comments on 1179bbdb

Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Reviewed-on: http://gerrit.cloudera.org:8080/5566
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit f3447a104fd5b6ca71122914838ea5f7d73c8efe)
Reviewed-on: http://gerrit.cloudera.org:8080/5572
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/client/client.h
M src/kudu/client/write_op.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/partial_row.h
M src/kudu/common/partition-test.cc
M src/kudu/common/types-test.cc
M src/kudu/tools/tool_main.cc
M src/kudu/util/logging.h
8 files changed, 35 insertions(+), 10 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.2.x) KUDU-1812. address comments on 1179bbdb

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: KUDU-1812. address comments on 1179bbdb
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No