You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/09 03:36:59 UTC

[GitHub] [fineract] vorburger opened a new pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

vorburger opened a new pull request #855:
URL: https://github.com/apache/fineract/pull/855


   FINERACT-858


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #855:
URL: https://github.com/apache/fineract/pull/855#issuecomment-626099085


   @ptuomola how do you like this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola edited a comment on pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

Posted by GitBox <gi...@apache.org>.
ptuomola edited a comment on pull request #855:
URL: https://github.com/apache/fineract/pull/855#issuecomment-629457457


   Looks good to me - much cleaner than the previous code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #855:
URL: https://github.com/apache/fineract/pull/855#issuecomment-626189891


   > @ptuomola how do you like this?
   
   @ptuomola and now this actually even builds green :smiley_cat: 
   
   @maektwain @awasum @xurror anyone else review this - LGTY?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #855:
URL: https://github.com/apache/fineract/pull/855#issuecomment-629457457


   Looks good to me - much cleaner than the previous approach


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #855:
URL: https://github.com/apache/fineract/pull/855#issuecomment-629385357


   It sounds like nobody seems to have any strong objections to this one, so I'd like to "self merge" it tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum merged pull request #855: rewrite MultiException to actually contain all causes (FINERACT-858)

Posted by GitBox <gi...@apache.org>.
awasum merged pull request #855:
URL: https://github.com/apache/fineract/pull/855


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org