You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by André Malo <nd...@perlig.de> on 2005/11/02 11:48:59 UTC

Re: svn commit: r227435 - in /httpd/httpd/branches/2.0.x: CHANGES STATUS modules/proxy/proxy_util.c

* jim@apache.org wrote:

> Author: jim
> Date: Thu Aug  4 10:07:57 2005
> New Revision: 227435
>
> URL: http://svn.apache.org/viewcvs?rev=227435&view=rev
> Log:
> mod_proxy: Fix over-eager handling of '%' for reverse proxies.  PR 29554.

Note that this patch broke certain RewriteRules out there, which proxy URLs 
with path parameters (http://foo/bar;param?query). It might be questionable 
if the Rules were written wrong in the first place, but they are broken by 
the update to 2.0.55 now.

For example, I have something like this (shortened):
RewriteMap e int:escape
RewriteRule ^/+(.*) \
    http://backend/${e:$1}?i=${e:%{REMOTE_ADDR}}%{ENV:NEW_QUERY} [P,NE]

If $1 contains a ';', it is escaped by the map to %3B but no longer 
unescaped by mod_proxy.

A possible solution would be, of course to be more careful with the rule 
(splitting at the ;). A more general solution would be to add ; to the safe 
T_OS_ESCAPE_PATH characters in gen_test_char.c. I'd prefer to do the latter 
but dunno if there may be problems on non-unices.

What do you think?

nd
-- 
"Das Verhalten von Gates hatte mir bewiesen, dass ich auf ihn und seine
beiden Gefährten nicht zu zählen brauchte" -- Karl May, "Winnetou III"

Im Westen was neues: <http://pub.perlig.de/books.html#apache2>

Re: svn commit: r227435 - in /httpd/httpd/branches/2.0.x: CHANGES STATUS modules/proxy/proxy_util.c

Posted by André Malo <nd...@perlig.de>.
Nobody?

* André Malo wrote:

> Anyone?
>
> * Andr__ Malo <nd...@perlig.de> wrote:
> > * jim@apache.org wrote:
> > > Author: jim
> > > Date: Thu Aug  4 10:07:57 2005
> > > New Revision: 227435
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=227435&view=rev
> > > Log:
> > > mod_proxy: Fix over-eager handling of '%' for reverse proxies.  PR
> > > 29554.
> >
> > Note that this patch broke certain RewriteRules out there, which proxy
> > URLs with path parameters (http://foo/bar;param?query). It might be
> > questionable if the Rules were written wrong in the first place, but
> > they are broken by the update to 2.0.55 now.
> >
> > For example, I have something like this (shortened):
> > RewriteMap e int:escape
> > RewriteRule ^/+(.*) \
> >     http://backend/${e:$1}?i=${e:%{REMOTE_ADDR}}%{ENV:NEW_QUERY} [P,NE]
> >
> > If $1 contains a ';', it is escaped by the map to %3B but no longer
> > unescaped by mod_proxy.
> >
> > A possible solution would be, of course to be more careful with the
> > rule (splitting at the ;). A more general solution would be to add ; to
> > the safe T_OS_ESCAPE_PATH characters in gen_test_char.c. I'd prefer to
> > do the latter but dunno if there may be problems on non-unices.
> >
> > What do you think?
> >
> > nd
> > --
> > "Das Verhalten von Gates hatte mir bewiesen, dass ich auf ihn und seine
> > beiden Gefährten nicht zu zählen brauchte" -- Karl May, "Winnetou III"
> >
> > Im Westen was neues: <http://pub.perlig.de/books.html#apache2>

-- 
"Umfassendes Werk (auch fuer Umsteiger vom Apache 1.3)"
                                          -- aus einer Rezension

<http://pub.perlig.de/books.html#apache2>

Re: svn commit: r227435 - in /httpd/httpd/branches/2.0.x: CHANGES STATUS modules/proxy/proxy_util.c

Posted by André Malo <nd...@perlig.de>.
Anyone?

* Andr__ Malo <nd...@perlig.de> wrote:

> * jim@apache.org wrote:
> 
> > Author: jim
> > Date: Thu Aug  4 10:07:57 2005
> > New Revision: 227435
> >
> > URL: http://svn.apache.org/viewcvs?rev=227435&view=rev
> > Log:
> > mod_proxy: Fix over-eager handling of '%' for reverse proxies.  PR 29554.
> 
> Note that this patch broke certain RewriteRules out there, which proxy URLs 
> with path parameters (http://foo/bar;param?query). It might be questionable 
> if the Rules were written wrong in the first place, but they are broken by 
> the update to 2.0.55 now.
> 
> For example, I have something like this (shortened):
> RewriteMap e int:escape
> RewriteRule ^/+(.*) \
>     http://backend/${e:$1}?i=${e:%{REMOTE_ADDR}}%{ENV:NEW_QUERY} [P,NE]
> 
> If $1 contains a ';', it is escaped by the map to %3B but no longer 
> unescaped by mod_proxy.
> 
> A possible solution would be, of course to be more careful with the rule 
> (splitting at the ;). A more general solution would be to add ; to the safe 
> T_OS_ESCAPE_PATH characters in gen_test_char.c. I'd prefer to do the latter 
> but dunno if there may be problems on non-unices.
> 
> What do you think?
> 
> nd
> -- 
> "Das Verhalten von Gates hatte mir bewiesen, dass ich auf ihn und seine
> beiden Gefährten nicht zu zählen brauchte" -- Karl May, "Winnetou III"
> 
> Im Westen was neues: <http://pub.perlig.de/books.html#apache2>
>