You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/30 20:17:51 UTC

[GitHub] [accumulo] EdColeman commented on a change in pull request #1813: Remove some unused code

EdColeman commented on a change in pull request #1813:
URL: https://github.com/apache/accumulo/pull/1813#discussion_r532873982



##########
File path: test/src/main/java/org/apache/accumulo/test/VolumeChooserIT.java
##########
@@ -132,7 +129,7 @@ public void configure(MiniAccumuloConfigImpl cfg, Configuration hadoopCoreSite)
 
     // Only add volumes 1, 2, and 4 to the list of instance volumes to have one volume that isn't in
     // the options list when they are choosing
-    cfg.setProperty(Property.INSTANCE_VOLUMES, v1 + "," + v2 + "," + v4);
+    cfg.setProperty(Property.INSTANCE_VOLUMES, v1 + "," + v2 + "," + v3);

Review comment:
       From a quick look, it seems this test trying to create a "hole" - does this invalidate the test if all volumes are present?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org