You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Isaac-Zhang (GitHub)" <gi...@apache.org> on 2020/02/28 02:52:51 UTC
[GitHub] [dubbo-go] Isaac-Zhang opened pull request #379: added
architecture files
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
added architecture files: png & pptx
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `72.03% <0%> (+3.38%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `73.52% <0%> (+8.82%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...2711ab9](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
========================================
Coverage 67.01% 67.01%
========================================
Files 157 157
Lines 8239 8239
========================================
Hits 5521 5521
Misses 2193 2193
Partials 525 525
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...5dadbff](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...5dadbff](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
==========================================
+ Coverage 67.01% 67.11% +0.1%
==========================================
Files 157 157
Lines 8239 8239
==========================================
+ Hits 5521 5530 +9
+ Misses 2193 2186 -7
+ Partials 525 523 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `72.03% <0%> (+3.38%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `73.52% <0%> (+8.82%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...2bdd8ea](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `72.03% <0%> (+3.38%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `73.52% <0%> (+8.82%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...2711ab9](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...b672da6](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #379: added architecture
files
Posted by "zouyx (GitHub)" <gi...@apache.org>.

I think the first space should similart to the second space.
@AlexStocks @hxmhlt @fangyincheng
Should the pptx file move to another project, like https://github.com/dubbogo/resources ?
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...5dadbff](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #379: added
architecture files
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
LGTM
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.04% +0.03%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5524 +3
+ Misses 2193 2190 -3
Partials 525 525
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `73.52% <0%> (+8.82%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...7ec0f9c](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...5dadbff](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] Isaac-Zhang commented on issue #379: added
architecture files
Posted by "Isaac-Zhang (GitHub)" <gi...@apache.org>.
removed the source file of pptx.
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
========================================
Coverage 67.01% 67.01%
========================================
Files 157 157
Lines 8239 8239
========================================
Hits 5521 5521
Misses 2193 2193
Partials 525 525
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...5dadbff](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #379: added architecture
files
Posted by "zouyx (GitHub)" <gi...@apache.org>.
1. I think the first space should same to the second space.

2. Should more space like provider block.

3. Spacing to parent should be consistent, **Config center** should be aligned.

@AlexStocks @hxmhlt @fangyincheng
Should the pptx file move to another project, like https://github.com/dubbogo/resources ?
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] Isaac-Zhang commented on issue #379: added
architecture files
Posted by "Isaac-Zhang (GitHub)" <gi...@apache.org>.
> 1. I think the first space should same to the second space.
>
> 
>
> 1. Should more space like provider block.
>
> 
>
> 1. Spacing to parent should be consistent, **Config center** should be aligned.
>
> 
>
> @AlexStocks @hxmhlt @fangyincheng
>
> Should the pptx file move to another project, like https://github.com/dubbogo/resources ?
1&2&3 Done.
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #379: added
architecture files
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=h1) Report
> Merging [#379](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359a42953b16cbf219a35e342e99809808cf9cb7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
+ Coverage 67.01% 67.09% +0.08%
===========================================
Files 157 157
Lines 8239 8239
===========================================
+ Hits 5521 5528 +7
+ Misses 2193 2187 -6
+ Partials 525 524 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <0%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <0%> (ø)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (ø)` | :arrow_up: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <0%> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <0%> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <0%> (ø)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.8% <0%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/379/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=footer). Last update [359a429...5dadbff](https://codecov.io/gh/apache/dubbo-go/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/379 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org