You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2017/07/09 00:48:02 UTC
commons-dbutils git commit: Always use blocks.
Repository: commons-dbutils
Updated Branches:
refs/heads/master 472b3d9c3 -> 14b6be0f9
Always use blocks.
Project: http://git-wip-us.apache.org/repos/asf/commons-dbutils/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-dbutils/commit/14b6be0f
Tree: http://git-wip-us.apache.org/repos/asf/commons-dbutils/tree/14b6be0f
Diff: http://git-wip-us.apache.org/repos/asf/commons-dbutils/diff/14b6be0f
Branch: refs/heads/master
Commit: 14b6be0f9bedbee60aed7bdc737b8132213cbded
Parents: 472b3d9
Author: Gary Gregory <ga...@gmail.com>
Authored: Sat Jul 8 17:48:00 2017 -0700
Committer: Gary Gregory <ga...@gmail.com>
Committed: Sat Jul 8 17:48:00 2017 -0700
----------------------------------------------------------------------
.../apache/commons/dbutils/AsyncQueryRunnerTest.java | 9 ++++++---
.../org/apache/commons/dbutils/QueryRunnerTest.java | 15 ++++++++++-----
.../wrappers/SqlNullCheckedResultSetTest.java | 4 +++-
3 files changed, 19 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-dbutils/blob/14b6be0f/src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java b/src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java
index eaee989..24f3900 100644
--- a/src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java
@@ -146,8 +146,9 @@ public class AsyncQueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
@@ -285,8 +286,9 @@ public class AsyncQueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
@@ -420,8 +422,9 @@ public class AsyncQueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
http://git-wip-us.apache.org/repos/asf/commons-dbutils/blob/14b6be0f/src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java b/src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java
index 55a9988..95e7662 100644
--- a/src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java
@@ -153,8 +153,9 @@ public class QueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
@@ -292,8 +293,9 @@ public class QueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
@@ -487,8 +489,9 @@ public class QueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
@@ -710,8 +713,9 @@ public class QueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
@@ -945,8 +949,9 @@ public class QueryRunnerTest {
caught = true;
}
- if(!caught)
+ if(!caught) {
fail("Exception never thrown, but expected");
+ }
}
@Test
http://git-wip-us.apache.org/repos/asf/commons-dbutils/blob/14b6be0f/src/test/java/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java b/src/test/java/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java
index e40f8b7..a872521 100644
--- a/src/test/java/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java
+++ b/src/test/java/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java
@@ -195,7 +195,9 @@ public class SqlNullCheckedResultSetTest extends BaseTestCase {
}
private static void assertArrayEquals(byte[] expected, byte[] actual) {
- if (expected == actual) return;
+ if (expected == actual) {
+ return;
+ }
if (expected.length != actual.length) {
failNotEquals(null, Arrays.toString(expected), Arrays.toString(actual));
}