You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Arsnael (via GitHub)" <gi...@apache.org> on 2023/12/21 10:37:38 UTC
[PR] JAMES-2586 Implement Postgresql search overrides [james-project]
Arsnael opened a new pull request, #1874:
URL: https://github.com/apache/james-project/pull/1874
Todo:
- [x] AllSearchOverride
- [ ] DeletedSearchOverride
- [ ] DeletedWithRangeSearchOverride
- [ ] NotDeletedWithRangeSearchOverride
- [ ] UidSearchOverride
- [ ] UnseenSearchOverride
Technically, if I'm not wrong, with the searchModuleChooser integrated, the conf is already there, and there is no need to care about bindings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Implement Postgresql search overrides [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1874:
URL: https://github.com/apache/james-project/pull/1874#issuecomment-1868717795
Rebased, added a missing license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Implement Postgresql search overrides [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1874:
URL: https://github.com/apache/james-project/pull/1874#discussion_r1435935903
##########
mailbox/postgres/src/test/java/org/apache/james/mailbox/postgres/search/SearchOverrideFixture.java:
##########
@@ -0,0 +1,52 @@
+package org.apache.james.mailbox.postgres.search;
Review Comment:
License missing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Implement Postgresql search overrides [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1874:
URL: https://github.com/apache/james-project/pull/1874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Implement Postgresql search overrides [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1874:
URL: https://github.com/apache/james-project/pull/1874#issuecomment-1868737625
> we should use Postgres indexes where appropriate IMO.
For the SearchOverrides the indexes are already in place, I'm between branches but check the modules where the PostgresMailboxMessageDAO is declared, there is 5 indexes declared with it, covering the cases of the search overrides IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org