You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:41:29 UTC

[GitHub] [incubator-nuttx] johannes-nivus opened a new pull request #1478: FAT Filesystem: UTF8 support for long filenames, bugfixes.

johannes-nivus opened a new pull request #1478:
URL: https://github.com/apache/incubator-nuttx/pull/1478


   
   ## Summary
   New CONFIG_FAT_LFN_UTF8: UTF8 strings are converted to UCS2-LFN
   Bugfix in fat_createalias: space is now also converted to underbar.
   Change (bugfix) in fat_getlfname: init characters (0xff) and '\0' are rewound as well.
   
   ## Impact
   When activating CONFIG_FAT_LFN_UTF8 the full 3byte UTF8 space is converted to UCS2 for long filenames, which allows e.g. for chinese characters in folder and file names.
   The bug in createalias caused problems with names including space characters.
   
   ## Testing
   Tested with mkdir on nsh and with apps/testing/fatutf8 (seperate commit on nuttx-apps)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1478: FAT Filesystem: UTF8 support for long filenames, bugfixes.

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1478:
URL: https://github.com/apache/incubator-nuttx/pull/1478#issuecomment-665626298


   Build / macOS (sim) (pull_request) Failing after 45m — macOS (sim)
   
   This is because of empty for-loops:
   ```for (namelen = 0; dirinfo->fd_lfname[namelen] != '\0'; namelen++);```
   Since coding standard encourages empty while-loops, I thought this correct for for-loops as well.
   Can someone comment?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1478: FAT Filesystem: UTF8 support for long filenames, bugfixes.

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1478:
URL: https://github.com/apache/incubator-nuttx/pull/1478#issuecomment-666957717


   Closed temporarily. I see unexpected behaviour sometimes, which I'd like to make sure isn't related.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus closed pull request #1478: FAT Filesystem: UTF8 support for long filenames, bugfixes.

Posted by GitBox <gi...@apache.org>.
johannes-nivus closed pull request #1478:
URL: https://github.com/apache/incubator-nuttx/pull/1478


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org