You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/03/18 14:32:13 UTC

[GitHub] [knox] moresandeep commented on a change in pull request #75: KNOX-1828 Fix Websocket Message Size

moresandeep commented on a change in pull request #75: KNOX-1828 Fix Websocket Message Size
URL: https://github.com/apache/knox/pull/75#discussion_r266468392
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
 ##########
 @@ -87,6 +87,8 @@ public void onWebSocketConnect(final Session frontEndSession) {
      * plumbing takes place
      */
     container = ContainerProvider.getWebSocketContainer();
+    container.setDefaultMaxBinaryMessageBufferSize(Integer.MAX_VALUE);
+    container.setDefaultMaxTextMessageBufferSize(Integer.MAX_VALUE);
 
 Review comment:
   The backendSession has hardcoded Integer.MAX_VALUE unfortunately which needs to be fixed as well, feel free to open a bug and I will fix this. It appears that this value has no effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services