[GitHub] [beam] ibzib commented on pull request #15151: [BEAM-12595] Add a dep in maven archetype example for Flink runner

[GitBox <gi...@apache.org>]

ibzib commented on pull request #15151:
URL: https://github.com/apache/beam/pull/15151#issuecomment-877387556


   Thanks for the feedback Tianzi.
   
   > @ibzib Thanks for the comment. I'm not sure what EMR is. I came across this while trying the example on Google Cloud Platform Dataproc with Flink.
   > 
   > https://cloud.google.com/dataproc/docs/concepts/components/flink#running_apache_beam_jobs
   > 
   > A broader fix will be nice. Anything I can do to help get that one unblocked?
   
   EMR is Amazon's cluster manager, similar to Dataproc on GCP. If the problem is happening to you on Dataproc, it shows the problem is obviously not with EMR.
   
   > Coincidentally, I see the Spark runner also lists a Jackson dep in the pom file, which makes me think that this fix is probably okay to be accepted.
   
   If we define the dependency in the runner itself, we shouldn't need to define it in the example POM as well. So I'm guessing that dependency is redundant and can be removed. https://github.com/apache/beam/blob/7724cfe900dd99ba651a62c976b51b486eb69885/runners/spark/spark_runner.gradle#L169-L173
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org