You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:08:52 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #12048: Fix FAB table views overflow
ryanahamilton opened a new pull request #12048:
URL: https://github.com/apache/airflow/pull/12048
Resolves #12030.
This could potentially be better resolved in FAB itself, but the issue is caused by the context of Airflow's tables having a large number of columns (very wide). This solution is similar to #11958 where the body will scroll horizontal instead of breaking the layout.
| Before | After |
|---|---|
|  |  |
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12048: Fix FAB table views overflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12048:
URL: https://github.com/apache/airflow/pull/12048#issuecomment-720580140
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #12048: Fix FAB table views overflow
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #12048:
URL: https://github.com/apache/airflow/pull/12048#issuecomment-720603455
Nice. not sure if doable but it makes more sense that the page numbing (same row as record countdown) will stay static and won't move when scrolled to the sides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #12048: Fix FAB table views overflow
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #12048:
URL: https://github.com/apache/airflow/pull/12048#issuecomment-720605868
@RosterIn I agree that would be ideal. Given these views are generated by FAB, we'd need to add extra markup/CSS classes there to resolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12048: Fix FAB table views overflow
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12048:
URL: https://github.com/apache/airflow/pull/12048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton edited a comment on pull request #12048: Fix FAB table views overflow
Posted by GitBox <gi...@apache.org>.
ryanahamilton edited a comment on pull request #12048:
URL: https://github.com/apache/airflow/pull/12048#issuecomment-720605868
@RosterIn I agree that would be ideal. Given these views are generated by [FAB](https://github.com/dpgaspar/Flask-AppBuilder), we'd need to add extra markup/CSS classes there to resolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org