You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/04 17:50:17 UTC

[GitHub] [tinkerpop] xiazcy commented on pull request #1743: Cast Times serialization to int in Gremlin-Go

xiazcy commented on PR #1743:
URL: https://github.com/apache/tinkerpop/pull/1743#issuecomment-1174036128

   > `makeBytecodeRequest` could be modified to return `(request, error)` and `(*Client).submitBytecode` could [return with error if it fails](https://github.com/apache/tinkerpop/blob/40508a427756d088d38b2236837c09db5dd1f2cd/gremlin-go/driver/client.go#L161). That would allow to check that the conversion is valid before sending it to the server.
   > 
   @jroimartin That may work, and I suppose it would involve checking within a range of bytecode steps that needs casting and perform the cast? Although in that case would we want to add this extra check for every bytecode request we make? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org