[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2958: sched/task: fix pthread call exit() failed

[GitBox <gi...@apache.org>]

patacongo edited a comment on pull request #2958:
URL: https://github.com/apache/incubator-nuttx/pull/2958#issuecomment-789699044


   I am confused.  The functions that you added references to tg_task to are conditioned on:
   
   ```
   #ifndef CONFIG_DISABLE_PTHREAD
         info.si_pid             = chgrp->tg_task;
   #else
         info.si_pid             = ctcb->pid;
   #endif
   ```
   
   But in include/nuttx/sched.h:
   
   ```
    474 #if !defined(CONFIG_DISABLE_PTHREAD) && defined(CONFIG_SCHED_HAVE_PARENT)
    475   pid_t tg_task;                    /* The ID of the task within the group      */
    476 #endif
   ```
   
   Have you tried building this with pthreads disabled or parent support not enabled?
   
   #2518 would required that tg_task be compled into the group structure unconditionally.  So if this were included as a part of #2518, then tg_task would always be available.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org