svn commit: r1155433 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java

[hl...@apache.org]

Author: hlship
Date: Tue Aug  9 16:48:19 2011
New Revision: 1155433

URL: http://svn.apache.org/viewvc?rev=1155433&view=rev
Log:
Ensure that ProxyFactory.getConstructorLocation() can not return null

Modified:
    tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java

Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java?rev=1155433&r1=1155432&r2=1155433&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java Tue Aug  9 16:48:19 2011
@@ -31,8 +31,6 @@ import java.util.List;
 
 public class PlasticProxyFactoryImpl implements PlasticProxyFactory
 {
-    private final Logger logger;
-
     private final PlasticManager manager;
 
     private final ClassLoader loader;
@@ -40,7 +38,6 @@ public class PlasticProxyFactoryImpl imp
     public PlasticProxyFactoryImpl(ClassLoader parentClassLoader, Logger logger)
     {
         this.loader = parentClassLoader;
-        this.logger = logger;
 
         manager = PlasticManager.withClassLoader(parentClassLoader).create();
 
@@ -141,10 +138,10 @@ public class PlasticProxyFactoryImpl imp
         ClassNode classNode = readClassNode(member.getDeclaringClass());
 
         if (classNode == null)
-            return null;
-
-        if (classNode.sourceFile == null)
-            return null;
+        {
+            throw new RuntimeException(String.format("Unable to read class file for %s (to gather line number information).",
+                    textDescription));
+        }
 
         for (MethodNode mn : (List<MethodNode>) classNode.methods)
         {