[jira] [Commented] (MNG-7636) Partially revert MNG-5868 to restore backward compatibility (see MNG-7316)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648948#comment-17648948 ] 

ASF GitHub Bot commented on MNG-7636:
-------------------------------------

michael-o opened a new pull request, #918:
URL: https://github.com/apache/maven/pull/918

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue. Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
          title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Partially revert MNG-5868 to restore backward compatibility (see MNG-7316)
> --------------------------------------------------------------------------
>
>                 Key: MNG-7636
>                 URL: https://issues.apache.org/jira/browse/MNG-7636
>             Project: Maven
>          Issue Type: Task
>    Affects Versions: 3.8.6
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.8.7
>
>
> Due to the lack of documentation it was never clear whether {{org.apache.maven.project.MavenProject.getAttachedArtifacts()}} is mutable or not. Components used or abused this collection. The change was done in 3.8.x in a patch release which was unfortunately and make things obvious. To better address the breaking situation this change will be partially reverted in 3.8.x, but documented in 3.9.0 and 4.0.0 that the collection is read-only. A proper solution to remove attached is desired in the future.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)