[GitHub] [kafka] cmccabe commented on a change in pull request #10043: MINOR: Add StorageTool as specified in KIP-631

[GitBox <gi...@apache.org>]

cmccabe commented on a change in pull request #10043:
URL: https://github.com/apache/kafka/pull/10043#discussion_r572338881



##########
File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala
##########
@@ -88,9 +88,9 @@ class RawMetaProperties(val props: Properties = new Properties()) {
   }
 
   override def toString: String = {
-    "RawMetaProperties(" + props.keySet().asScala.toList.asInstanceOf[List[String]].sorted.map {
+    "{" + props.keySet().asScala.toList.asInstanceOf[List[String]].sorted.map {

Review comment:
       It doesn't produce JSON (for example, keys and values are not quoted).
   
   This is intended for human consumption.  It will show up in the command-line output.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org