You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/03/18 02:08:56 UTC

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2538: hw/drivers/buzzer: Tone generator with the PWM peripheral

apache-mynewt-bot removed a comment on pull request #2538:
URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-801554135


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/drivers/buzzer/src/buzzer.c
   <details>
   
   ```diff
   @@ -27,7 +27,7 @@
    #define BUZZER_PWM_CHAN 0
    
    #if BUZZER_PIN >= 0
   -struct pwm_dev* _pwm_dev;
   +struct pwm_dev * _pwm_dev;
    #endif
    
    /***
   @@ -87,13 +87,10 @@
    buzzer_tone_on(uint32_t freq)
    {
    #if BUZZER_PIN >= 0
   -    if (freq == 0)
   -    {
   +    if (freq == 0) {
            /* stop PWM */
            pwm_set_duty_cycle(_pwm_dev, BUZZER_PWM_CHAN, 0);
   -    }
   -    else
   -    {
   +    } else   {
            /* set frequency */
            pwm_set_frequency(_pwm_dev, freq);
    
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org