You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/02/09 13:48:11 UTC
[GitHub] [incubator-eventmesh] mxsm opened a new pull request, #3079: [ISSUE #3078]Refactor ThreadUtils
mxsm opened a new pull request, #3079:
URL: https://github.com/apache/incubator-eventmesh/pull/3079
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixes #3078
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Refactor ThreadUtils*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3079: [ISSUE #3078]Refactor ThreadUtils
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3079:
URL: https://github.com/apache/incubator-eventmesh/pull/3079#discussion_r1102181889
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/ThreadUtils.java:
##########
@@ -20,22 +20,45 @@
import org.apache.logging.log4j.util.ProcessIdUtil;
import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
public class ThreadUtils {
private static volatile long currentPID = -1;
- public static void randomSleep(int min, int max) throws Exception {
- // nextInt is normally exclusive of the top value, so add 1 to make it inclusive
- int random = ThreadLocalRandom.current().nextInt(min, max + 1);
- Thread.sleep(random);
+ public static void randomSleep(long min, long max) {
Review Comment:
Suggest to rename method will be better.
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/ThreadUtils.java:
##########
@@ -20,22 +20,45 @@
import org.apache.logging.log4j.util.ProcessIdUtil;
import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
public class ThreadUtils {
private static volatile long currentPID = -1;
- public static void randomSleep(int min, int max) throws Exception {
- // nextInt is normally exclusive of the top value, so add 1 to make it inclusive
- int random = ThreadLocalRandom.current().nextInt(min, max + 1);
- Thread.sleep(random);
+ public static void randomSleep(long min, long max) {
+ randomSleep(min, max, TimeUnit.MILLISECONDS);
+ }
+ public static void randomSleep(long min, long max, TimeUnit timeUnit) {
Review Comment:
Suggest to rename method will be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3079: [ISSUE #3078]Refactor ThreadUtils
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3079:
URL: https://github.com/apache/incubator-eventmesh/pull/3079#discussion_r1102182164
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/ThreadUtils.java:
##########
@@ -20,22 +20,45 @@
import org.apache.logging.log4j.util.ProcessIdUtil;
import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
public class ThreadUtils {
private static volatile long currentPID = -1;
- public static void randomSleep(int min, int max) throws Exception {
- // nextInt is normally exclusive of the top value, so add 1 to make it inclusive
- int random = ThreadLocalRandom.current().nextInt(min, max + 1);
- Thread.sleep(random);
+ public static void randomSleep(long min, long max) {
+ randomSleep(min, max, TimeUnit.MILLISECONDS);
+ }
+ public static void randomSleep(long min, long max, TimeUnit timeUnit) {
+ // nextInt is normally exclusive of the top value, so add 1 to make it inclusive
+ try {
+ long timeout = ThreadLocalRandom.current().nextLong(min, max + 1);
+ timeUnit.sleep(timeout);
+ } catch (InterruptedException ignore) {
+ //ignore
+ }
}
- public static void randomSleep(int max) throws Exception {
+ public static void randomSleep(long max) {
Review Comment:
Suggest to rename method will be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3079: [ISSUE #3078]Refactor ThreadUtils
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3079:
URL: https://github.com/apache/incubator-eventmesh/pull/3079#discussion_r1102228907
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/ThreadUtils.java:
##########
@@ -20,22 +20,45 @@
import org.apache.logging.log4j.util.ProcessIdUtil;
import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
public class ThreadUtils {
private static volatile long currentPID = -1;
- public static void randomSleep(int min, int max) throws Exception {
- // nextInt is normally exclusive of the top value, so add 1 to make it inclusive
- int random = ThreadLocalRandom.current().nextInt(min, max + 1);
- Thread.sleep(random);
+ public static void randomSleep(long min, long max) {
+ randomSleep(min, max, TimeUnit.MILLISECONDS);
+ }
+ public static void randomSleep(long min, long max, TimeUnit timeUnit) {
+ // nextInt is normally exclusive of the top value, so add 1 to make it inclusive
+ try {
+ long timeout = ThreadLocalRandom.current().nextLong(min, max + 1);
+ timeUnit.sleep(timeout);
+ } catch (InterruptedException ignore) {
+ //ignore
+ }
}
- public static void randomSleep(int max) throws Exception {
+ public static void randomSleep(long max) {
Review Comment:
> Suggest to rename method will be better.
@jonyangx Good idea, I will do and resubmit the pr later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #3079: [ISSUE #3078]Refactor ThreadUtils
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx merged PR #3079:
URL: https://github.com/apache/incubator-eventmesh/pull/3079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3079: [ISSUE #3078]Refactor ThreadUtils
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3079:
URL: https://github.com/apache/incubator-eventmesh/pull/3079#issuecomment-1424275383
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3079](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (222ad82) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/b2885b20a4fb7c0fc03430eeafb9e2a524675d24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2885b2) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3079 +/- ##
============================================
- Coverage 12.86% 12.81% -0.06%
+ Complexity 1100 1096 -4
============================================
Files 548 548
Lines 28646 28649 +3
Branches 2868 2856 -12
============================================
- Hits 3686 3672 -14
- Misses 24642 24662 +20
+ Partials 318 315 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/eventmesh/common/utils/ThreadUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9UaHJlYWRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...eventmesh/runtime/boot/AbstractRemotingServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RSZW1vdGluZ1NlcnZlci5qYXZh) | `5.12% <0.00%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `29.41% <0.00%> (-17.65%)` | :arrow_down: |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `31.64% <0.00%> (-7.60%)` | :arrow_down: |
| [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `91.20% <0.00%> (-0.34%)` | :arrow_down: |
| [...rg/apache/eventmesh/runtime/trace/LogExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL0xvZ0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ime/admin/handler/RedirectClientByPathHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeVBhdGhIYW5kbGVyLmphdmE=) | `84.78% <0.00%> (ø)` | |
| [...e/admin/handler/RedirectClientByIpPortHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeUlwUG9ydEhhbmRsZXIuamF2YQ==) | `31.37% <0.00%> (ø)` | |
| [.../tcp/client/session/push/DownStreamMsgContext.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvRG93blN0cmVhbU1zZ0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...l/tcp/client/recommend/EventMeshRecommendImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9yZWNvbW1lbmQvRXZlbnRNZXNoUmVjb21tZW5kSW1wbC5qYXZh) | `0.83% <0.00%> (+<0.01%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org