You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/05/22 01:40:47 UTC
Review Request 59431: RANGER-1596 The log name is incorrect in
Log4JAuditDestination.java.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59431/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1596
https://issues.apache.org/jira/browse/RANGER-1596
Repository: ranger
Description
-------
The log name should use 'Log4JAuditDestination.class' instead of 'FileAuditDestination.class' in Log4JAuditDestination.java.
Change from 'private static final Log logger = LogFactory.getLog(FileAuditDestination.class);' to 'private static final Log logger = LogFactory.getLog(Log4JAuditDestination.class);'
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/Log4JAuditDestination.java 4e3338ec
Diff: https://reviews.apache.org/r/59431/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 59431: RANGER-1596 The log name is incorrect in
Log4JAuditDestination.java.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59431/#review175604
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 22, 2017, 2:07 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59431/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 2:07 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1596
> https://issues.apache.org/jira/browse/RANGER-1596
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The log name should use 'Log4JAuditDestination.class' instead of 'FileAuditDestination.class' in Log4JAuditDestination.java.
> Change from 'private static final Log logger = LogFactory.getLog(FileAuditDestination.class);' to 'private static final Log logger = LogFactory.getLog(Log4JAuditDestination.class);'
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/Log4JAuditDestination.java 4e3338ec
>
>
> Diff: https://reviews.apache.org/r/59431/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 59431: RANGER-1596 The log name is incorrect in
Log4JAuditDestination.java.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59431/
-----------------------------------------------------------
(Updated 五月 22, 2017, 2:07 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1596
https://issues.apache.org/jira/browse/RANGER-1596
Repository: ranger
Description
-------
The log name should use 'Log4JAuditDestination.class' instead of 'FileAuditDestination.class' in Log4JAuditDestination.java.
Change from 'private static final Log logger = LogFactory.getLog(FileAuditDestination.class);' to 'private static final Log logger = LogFactory.getLog(Log4JAuditDestination.class);'
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/Log4JAuditDestination.java 4e3338ec
Diff: https://reviews.apache.org/r/59431/diff/2/
Changes: https://reviews.apache.org/r/59431/diff/1-2/
Testing
-------
Thanks,
Qiang Zhang