You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/06 13:50:35 UTC
[GitHub] [netbeans] mlvtito opened a new issue, #4587: Unit test on single file is converted to integration test
mlvtito opened a new issue, #4587:
URL: https://github.com/apache/netbeans/issues/4587
### Apache NetBeans version
Apache NetBeans 14
### What happened
I noticed that my Netesta plugin does not work anymore with Netbeans 14.
Each time it tries to apply ActionProvider.COMMAND_TEST_SINGLE,
### How to reproduce
I use Netesta plugin to automatically trigger unit tests on a single file
### Did this work correctly in an earlier version?
Apache NetBeans 13
### Operating System
Ubuntu
### JDK
1.8, 11, 17 & 18
### Apache NetBeans packaging
Apache NetBeans binary zip
### Anything else
I have done some debugging, so I can tell where the problem occurs.
In the class `DefaultReplaceTokenProvider`, in the method `isIntegrationTestTarget`, the variable `targetFiles` can be also empty (and not only `null`)
In this case, the `allMatch` method of the stream return `true` whereas there are no files.
### Are you willing to submit a pull request?
No
### Code of Conduct
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed issue #4587: Unit test on single file is converted to integration test
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net closed issue #4587: Unit test on single file is converted to integration test
URL: https://github.com/apache/netbeans/issues/4587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hemantsoni42 commented on issue #4587: Unit test on single file is converted to integration test
Posted by "hemantsoni42 (via GitHub)" <gi...@apache.org>.
hemantsoni42 commented on issue #4587:
URL: https://github.com/apache/netbeans/issues/4587#issuecomment-1407627888
Fixed Unit test on single file is converted to integration test #4587 #5381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hemantsoni42 commented on issue #4587: Unit test on single file is converted to integration test
Posted by "hemantsoni42 (via GitHub)" <gi...@apache.org>.
hemantsoni42 commented on issue #4587:
URL: https://github.com/apache/netbeans/issues/4587#issuecomment-1407592404
@neilcsmith-net can you please assign me this issue.
I already solve fork this and solved the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #4587: Unit test on single file is converted to integration test
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on issue #4587:
URL: https://github.com/apache/netbeans/issues/4587#issuecomment-1533209710
This should be fixed in 18-rc3. Please test when that is available next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #4587: Unit test on single file is converted to integration test
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #4587:
URL: https://github.com/apache/netbeans/issues/4587#issuecomment-1238206373
Looks like it should perhaps be using [extractFileObjectsfromLookup](https://github.com/apache/netbeans/blob/master/java/maven/src/org/netbeans/modules/maven/execute/DefaultReplaceTokenProvider.java#L86), although the extra check for empty would be good. Feel free to file a PR.
Also, looks like your plugin should really be fixed to pass FileObject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hemantsoni42 commented on issue #4587: Unit test on single file is converted to integration test
Posted by "hemantsoni42 (via GitHub)" <gi...@apache.org>.
hemantsoni42 commented on issue #4587:
URL: https://github.com/apache/netbeans/issues/4587#issuecomment-1407664878
@neilcsmith-net thank you sir for your help
I once again go through the code and file a different PR after adding an extra check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists