[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1589: MINIFICPP-1825 Create Properties at compile time

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1237222027


##########
extensions/gcp/processors/GCSProcessor.h:
##########
@@ -34,19 +38,33 @@ class GCSProcessor : public core::Processor {
  public:
   GCSProcessor(std::string name, const minifi::utils::Identifier& uuid, std::shared_ptr<core::logging::Logger> logger)
       : core::Processor(std::move(name), uuid),
-        logger_(std::move(logger)) {
+     #include "PropertyDefinitionBuilder.h"

Review Comment:
   Yes, thank you -- removed in bee1b6d8bb985c7cc817b9249470506d094cc0cb.
   
   I was wondering how this compiled, but of course the `#pragma once` caused this to be an empty include.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org