You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/13 18:31:08 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6524: NIFI-10567 Correct Sensitive Dynamic Property handling for flow.xml

exceptionfactory opened a new pull request, #6524:
URL: https://github.com/apache/nifi/pull/6524

   - Updated XmlFlowSynchronizer to filter parsed Sensitive Dynamic Property Names using dynamic status of component Property Descriptor
   - Lack of access to the Component Property Descriptor when parsing DOM elements required subsequent dynamic status filtering
   
   # Summary
   
   [NIFI-10567](https://issues.apache.org/jira/browse/NIFI-10567) Corrects the parsing of Sensitive Dynamic Properties read from the XML version of the flow configuration, in absence of the JSON version.
   
   The issue surfaces when upgrading to NiFi 1.17.0 or 1.18.0 from a version older than 1.16.0. The issue also requires the presence of a Parameter Context with a Sensitive value assigned to a component with a Sensitive Property. Upgrading from 1.16.0 and following is not a problem. Deleting the `flow.json.gz` configuration also triggers the problematic behavior.
   
   The following steps can be used to reproduce the problem on NiFi 1.18.0:
   
   1. Create a new Process Group
   2. Create and assign a new Parameter Context
   3. Create a Sensitive Parameter Value in the Parameter Context
   4. Create a Processor with a Sensitive Property
   5. Assign the Sensitive Parameter Value to the Processor Sensitive Property
   6. Stop NiFi
   7. Delete `flow.json.gz`
   8. Start NiFi
   
   After those steps, the Processor will be marked as invalid with an error indicating that Sensitive Dynamic Properties are configured but not supported.
   
   The changes correct the behavior of the XML synchronizer to filter Sensitive Property Names based on the dynamic status indicated when calling `getPropertyDescriptor()` on the associated component. Additional changes include the removal of an unused method from `ControllerServiceLoader` and non-applicable exceptions from several related methods.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #6524: NIFI-10567 Correct Sensitive Dynamic Property handling for flow.xml

Posted by GitBox <gi...@apache.org>.
markap14 merged PR #6524:
URL: https://github.com/apache/nifi/pull/6524


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6524: NIFI-10567 Correct Sensitive Dynamic Property handling for flow.xml

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6524:
URL: https://github.com/apache/nifi/pull/6524#issuecomment-1278287165

   Thanks @exceptionfactory the changes look good to me. +1 merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org