You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Marco Massenzio <ma...@mesosphere.io> on 2015/07/31 10:04:53 UTC

Review Request 36979: Updating all references to os::shell

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-3142
    https://issues.apache.org/jira/browse/MESOS-3142


Repository: mesos


Description
-------

Updating all references to os::shell
For more details see MESOS-3142.


Diffs
-----

  src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 
  src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
  src/slave/containerizer/isolators/network/port_mapping.cpp 3f6e9df8711995d0dd3903c6170fdd5ad61aac5a 
  src/tests/containerizer/isolator_tests.cpp ff6e2b7e190a58a4809d6e71addb15dabe418e17 
  src/tests/containerizer/port_mapping_tests.cpp 4bee74acba2b1472c80cabbc9d0384bd04c543aa 

Diff: https://reviews.apache.org/r/36979/diff/


Testing
-------

make check
*Note*: this patch fixes breakages introduce by the refactoring in: https://reviews.apache.org/r/36978


Thanks,

Marco Massenzio

Re: Review Request 36979: Updating all references to os::shell

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review93709
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36978, 36979]

All tests passed.

- Mesos ReviewBot


On July 31, 2015, 8:04 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36979/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:04 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3142
>     https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updating all references to os::shell
> For more details see MESOS-3142.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 3f6e9df8711995d0dd3903c6170fdd5ad61aac5a 
>   src/tests/containerizer/isolator_tests.cpp ff6e2b7e190a58a4809d6e71addb15dabe418e17 
>   src/tests/containerizer/port_mapping_tests.cpp 4bee74acba2b1472c80cabbc9d0384bd04c543aa 
> 
> Diff: https://reviews.apache.org/r/36979/diff/
> 
> 
> Testing
> -------
> 
> make check
> *Note*: this patch fixes breakages introduce by the refactoring in: https://reviews.apache.org/r/36978
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>