You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/12 18:01:23 UTC

[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #258: Add / Fix / Complete javadoc

arturobernalg commented on a change in pull request #258:
URL: https://github.com/apache/httpcomponents-core/pull/258#discussion_r575410273



##########
File path: httpcore5-h2/src/main/java/org/apache/hc/core5/http2/nio/AsyncPingHandler.java
##########
@@ -49,6 +49,8 @@
      * Triggered to signal receipt of a ping response message.
      *
      * @param feedback the ping message feedback.
+     * @throws IOException in case of an I/O error

Review comment:
       hi @ok2c maybe you're right. Any advice to how proceed now? I'm honestly miss the javadoc in the above class and don't think it's important give all information that we can to the user's.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org