You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by kent2171 <gi...@git.apache.org> on 2018/06/17 13:41:15 UTC
[GitHub] flink pull request #6176: [FLINK-9603][connector-filesystem] fix part indexi...
GitHub user kent2171 opened a pull request:
https://github.com/apache/flink/pull/6176
[FLINK-9603][connector-filesystem] fix part indexing, when part suffix is specified
This pull-request fixes problem of incorrect part file index lookup, when part suffix is specified.
Part file path should be assembled with part suffix, before check on existance
The following tests, that verify part file indexing, have been added:
- testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInProgressState
- testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInPendingState
- testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInFinalState
- testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInProgressState
- testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInPendingState
- testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInFinalState
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kent2171/flink FLINK-9603_fix_part_idx_inc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6176
----
commit c08b81044bf80d5633a9936afb73fadf021cef47
Author: Rinat Sharipov <r....@...>
Date: 2018-06-17T13:03:54Z
FLINK-9603 1. all logic, that is responsible for path assembly moved into method; 2. test logic of part file indexing, when in-progress/ pending/ final part files already exists in bucket; 3. test the same logic, when part file has suffix
----
---
[GitHub] flink issue #6176: [FLINK-9603][connector-filesystem] fix part indexing, whe...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6176
Thanks for the work @kent2171 ! I will merge this as soon as Travis gives the green light!
---
[GitHub] flink pull request #6176: [FLINK-9603][connector-filesystem] fix part indexi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6176
---
[GitHub] flink issue #6176: [FLINK-9603][connector-filesystem] fix part indexing, whe...
Posted by kent2171 <gi...@git.apache.org>.
Github user kent2171 commented on the issue:
https://github.com/apache/flink/pull/6176
cool, thx @kl0u
---
[GitHub] flink issue #6176: [FLINK-9603][connector-filesystem] fix part indexing, whe...
Posted by kent2171 <gi...@git.apache.org>.
Github user kent2171 commented on the issue:
https://github.com/apache/flink/pull/6176
nice to hear, thx you @kl0u
---
[GitHub] flink issue #6176: [FLINK-9603][connector-filesystem] fix part indexing, whe...
Posted by kent2171 <gi...@git.apache.org>.
Github user kent2171 commented on the issue:
https://github.com/apache/flink/pull/6176
@kl0u Kostas, build failed, and said `src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java:[965] (regexp) RegexpSinglelineJava: Line has leading space characters; indentation should be performed with tabs only.`
starts not from tab, I've checked in mine and yours repository, this line starts from 3 tabs, should I fix something ?
---
[GitHub] flink issue #6176: [FLINK-9603][connector-filesystem] fix part indexing, whe...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6176
Hi @kent2171 ! Do not worry, I can fix it ;) Thanks for having a look!
---