You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/20 06:55:43 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #116: [WIP]
- Add LDAP Account Form
utchoang opened a new pull request #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116
@rhtyd cc @svenvogel
This is my new design of the Add LDAP Account Form. Please review and let me know your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request
#116: [WIP] - Add LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#discussion_r368443937
##########
File path: src/components/view/ActionButton.vue
##########
@@ -44,7 +44,7 @@
v-if="action.api in $store.getters.apis &&
!action.showBadge &&
((!dataView && (action.listView || action.groupAction && selectedRowKeys.length > 0)) || (dataView && action.dataView)) &&
- ('show' in action ? action.show(resource, $store.getters.userInfo) : true)"
+ ('show' in action ? action.show(resource, $store.getters.userInfo, $store.getters.isLdapEnabled) : true)"
Review comment:
I'm thinking to get rid of this at this.$store must be accessible by all parts of the code; or simply only pass $store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576561653
@utchoang I started review it, looks like you still have git merge/branching issues. Did you follow the previously advised steps to fix your branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576186590
@rhtyd Yes. Please review and let me know your comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576590545
@utchoang the base branch you're checking out is not consistent with origin/master; i.e. your master is not same as origin/master. Kindly do this to fix it:
```
git fetch origin
git checkout master
git reset --hard origin/master
<then checkout any new branch for a new PR from your own local master, for example:>
git checkout -b feature/xyz...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576574152
@rhtyd I realized that the master branch is now changed compared to the moment I got it earlier. Do you mean that I should get the master once again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576185889
@utchoang is this ready for testing and reviewing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576530672
@utchoang thanks, will review later today/tomorrow and get back to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576503259
@utchoang you're right, you may refer to old code here:
https://github.com/apache/cloudstack/blob/5ff932eb868e88f298b2fb54af8bbcc688a4cc29/ui/scripts/ui-custom/accountsWizard.js#L137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576508482
@rhtyd @svenvogel I added the search filter section in the Ldap users list. Please review and let me know the comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576475556
@svenvogel OK. I understood.
@rhtyd I'll add new search filter and pagination for list users and you can review again...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576499056
@svenvogel According to http://cloudstack.apache.org/api/apidocs-4.13/apis/listLdapUsers.html. I did try to add search filter, however, this API does not support keyword filter or pagination. Thus, it is impossible to add search filter in this case. I have an alternative which is to filter on client only, not by API. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576210572
@utchoang thanks! cool! is is possible to add a search filter for the user? if you have many user you will find it easier...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576195634
fantastic @utchoang I'll review and test and get back to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #116: [WIP] - Add
LDAP Account Form
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services