You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jayush Luniya <jl...@hortonworks.com> on 2015/01/02 22:27:50 UTC
Re: Review Request 29009: Refactor the OS-dependent Ambari Server
Windows components - part 1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29009/#review66553
-----------------------------------------------------------
The latest patch attached to the review does not apply cleanly to trunk. Can you please refresh the patch?
hw11039:ambari jluniya$ git apply ~/Downloads/AMBARI-8373.patch
error: patch failed: ambari-common/src/main/python/ambari_commons/os_utils.py:108
error: ambari-common/src/main/python/ambari_commons/os_utils.py: patch does not apply
error: patch failed: ambari-common/src/main/python/ambari_commons/os_windows.py:487
error: ambari-common/src/main/python/ambari_commons/os_windows.py: patch does not apply
- Jayush Luniya
On Dec. 26, 2014, 9:17 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29009/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 9:17 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8373
> https://issues.apache.org/jira/browse/AMBARI-8373
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Refactored the Ambari Server setup+reset+update.
>
> +Pervasively adopted the OS-independent factory-based object model
> +Unwired the setup-related code from ambari-server.py into separate files.
> +Fixed the unit tests
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostInfo.py a99a85dc0e9a6a9e13c7ccc94741da0b83bb0710
> ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f
> ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa
> ambari-common/src/main/python/ambari_commons/os_family_impl.py f8a3379df35a7ff539ca67f213c8512c761b9c60
> ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723
> ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
> ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
> ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84
> ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875
> ambari-server/conf/unix/ambari.properties e29a6e25f576a8f806a447a4cf03c56f4d0c105b
> ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977
> ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f
> ambari-server/src/main/python/ambari-server.py 89caa2ea4caa726f206bdfbde03ae95a6af0f082
> ambari-server/src/main/python/ambari_server/dbConfiguration.py daa84abbfe507aafacb4f5e4f81be3864a2ea0e6
> ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
> ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 2d3996e17208b0bbe81004b1a6ac91358f9d9ba2
> ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15
> ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
> ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
> ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48
> ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70
> ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff
> ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337
> ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b2c4a50695cca3fb33fd72065d7f57f4ee
> ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1
>
> Diff: https://reviews.apache.org/r/29009/diff/
>
>
> Testing
> -------
>
> mvn clean test on CentOS
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29009: Refactor the OS-dependent Ambari Server
Windows components - part 1
Posted by Florian Barca <fb...@hortonworks.com>.
> On Jan. 2, 2015, 9:27 p.m., Jayush Luniya wrote:
> > The latest patch attached to the review does not apply cleanly to trunk. Can you please refresh the patch?
> >
> > hw11039:ambari jluniya$ git apply ~/Downloads/AMBARI-8373.patch
> > error: patch failed: ambari-common/src/main/python/ambari_commons/os_utils.py:108
> > error: ambari-common/src/main/python/ambari_commons/os_utils.py: patch does not apply
> > error: patch failed: ambari-common/src/main/python/ambari_commons/os_windows.py:487
> > error: ambari-common/src/main/python/ambari_commons/os_windows.py: patch does not apply
A patch this big was bound to have consistency issues and eventually dfall out of date. Will break the patch in several pieces.
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29009/#review66553
-----------------------------------------------------------
On Dec. 26, 2014, 9:17 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29009/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 9:17 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8373
> https://issues.apache.org/jira/browse/AMBARI-8373
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Refactored the Ambari Server setup+reset+update.
>
> +Pervasively adopted the OS-independent factory-based object model
> +Unwired the setup-related code from ambari-server.py into separate files.
> +Fixed the unit tests
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostInfo.py a99a85dc0e9a6a9e13c7ccc94741da0b83bb0710
> ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f
> ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa
> ambari-common/src/main/python/ambari_commons/os_family_impl.py f8a3379df35a7ff539ca67f213c8512c761b9c60
> ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723
> ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
> ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
> ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84
> ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875
> ambari-server/conf/unix/ambari.properties e29a6e25f576a8f806a447a4cf03c56f4d0c105b
> ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977
> ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f
> ambari-server/src/main/python/ambari-server.py 89caa2ea4caa726f206bdfbde03ae95a6af0f082
> ambari-server/src/main/python/ambari_server/dbConfiguration.py daa84abbfe507aafacb4f5e4f81be3864a2ea0e6
> ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
> ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 2d3996e17208b0bbe81004b1a6ac91358f9d9ba2
> ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15
> ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
> ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
> ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48
> ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70
> ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff
> ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337
> ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b2c4a50695cca3fb33fd72065d7f57f4ee
> ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1
>
> Diff: https://reviews.apache.org/r/29009/diff/
>
>
> Testing
> -------
>
> mvn clean test on CentOS
>
>
> Thanks,
>
> Florian Barca
>
>