You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aaron T. Myers (Created) (JIRA)" <ji...@apache.org> on 2012/02/04 02:41:53 UTC
[jira] [Created] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
HA: DFSUtil#getSuffixIDs should skip unset configurations
---------------------------------------------------------
Key: HDFS-2890
URL: https://issues.apache.org/jira/browse/HDFS-2890
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
Priority: Minor
This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200416#comment-13200416 ]
Hudson commented on HDFS-2890:
------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #68 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/68/])
HDFS-2890. DFSUtil#getSuffixIDs should skip unset configurations. Contributed by Aaron T. Myers.
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240447
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
> HA: DFSUtil#getSuffixIDs should skip unset configurations
> ---------------------------------------------------------
>
> Key: HDFS-2890
> URL: https://issues.apache.org/jira/browse/HDFS-2890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2890-HDFS-1623.patch, HDFS-2890-HDFS-1623.patch
>
>
> This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
Posted by "Aaron T. Myers (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers resolved HDFS-2890.
----------------------------------
Resolution: Fixed
Fix Version/s: HA branch (HDFS-1623)
Hadoop Flags: Reviewed
Thanks a lot for the reviews, Todd. I've just committed this to the HA branch.
> HA: DFSUtil#getSuffixIDs should skip unset configurations
> ---------------------------------------------------------
>
> Key: HDFS-2890
> URL: https://issues.apache.org/jira/browse/HDFS-2890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2890-HDFS-1623.patch, HDFS-2890-HDFS-1623.patch
>
>
> This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200296#comment-13200296 ]
Todd Lipcon commented on HDFS-2890:
-----------------------------------
lgtm, +1
> HA: DFSUtil#getSuffixIDs should skip unset configurations
> ---------------------------------------------------------
>
> Key: HDFS-2890
> URL: https://issues.apache.org/jira/browse/HDFS-2890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-2890-HDFS-1623.patch, HDFS-2890-HDFS-1623.patch
>
>
> This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-2890:
---------------------------------
Attachment: HDFS-2890-HDFS-1623.patch
I had included those changes in the patch on HDFS-2792. I'll move them all in here.
> HA: DFSUtil#getSuffixIDs should skip unset configurations
> ---------------------------------------------------------
>
> Key: HDFS-2890
> URL: https://issues.apache.org/jira/browse/HDFS-2890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-2890-HDFS-1623.patch, HDFS-2890-HDFS-1623.patch
>
>
> This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200287#comment-13200287 ]
Todd Lipcon commented on HDFS-2890:
-----------------------------------
Want to also include the other change you add, where the addr string is included in the WARN message in the catch clause below? Seemed useful.
> HA: DFSUtil#getSuffixIDs should skip unset configurations
> ---------------------------------------------------------
>
> Key: HDFS-2890
> URL: https://issues.apache.org/jira/browse/HDFS-2890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-2890-HDFS-1623.patch
>
>
> This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2890) HA: DFSUtil#getSuffixIDs should skip
unset configurations
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-2890:
---------------------------------
Attachment: HDFS-2890-HDFS-1623.patch
Trivial patch attached. This is identical to the change I made in the original patch posted on HDFS-2792. To test the change, I ran `hdfs fsck' with and without the patch, and confirmed that the warnings were not printed with the patch.
> HA: DFSUtil#getSuffixIDs should skip unset configurations
> ---------------------------------------------------------
>
> Key: HDFS-2890
> URL: https://issues.apache.org/jira/browse/HDFS-2890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-2890-HDFS-1623.patch
>
>
> This doesn't really cause any harm, but will cause warning messages to be printed when looking for configuration keys which are unset, e.g. when running `hdfs fsck' without having configured {{dfs.namenode.servicerpc-address}} keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira