You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/26 13:32:24 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #6981: [Improvement-6866][Api] Add transaction for service

caishunfeng commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r757499347



##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2225,6 +2236,7 @@ public String getResourceIds(TaskDefinition taskDefinition) {
         return StringUtils.join(resourceIds, ",");
     }
 
+    @Transactional

Review comment:
       hi @HomminLee , I found that it had a Transactional annotation on the outer layer, I'm not sure if there is a problem with nested transactions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org