You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by machristie <gi...@git.apache.org> on 2016/12/16 19:59:55 UTC
[GitHub] airavata pull request #89: AIRAVATA-2282 notification sort: Prevent int over...
GitHub user machristie opened a pull request:
https://github.com/apache/airavata/pull/89
AIRAVATA-2282 notification sort: Prevent int overflow
Instead of returning the difference as a long and casting to an int,
which risks integer overflow, just return 1 or -1 corresponding to the
sign of the difference.
Note: this branch was branched from master which is ahead of develop by a few spurious commits. My change for this bug fix is really just NotificationRegistry.java change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/machristie/airavata AIRAVATA-2282-notification-order
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 08c2766d448f085f43464ec49a81ddfa3bee8295
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T14:27:55Z
closes apache/airavata#2 #2 *Won't fix* the samples are now upto date with latest code
commit 00734058dec4309689802503a101adfe7a9bf2dc
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T14:29:54Z
closes apache/airavata#14 the fixes were applied but PR was not closed, closing now
commit e45e07eee4f2f74dd922749a7b1a5cf71bbf1574
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T14:38:11Z
closes apache/airavata#15 the fixes were applied but PR was not closed, closing now
commit 3aecdd20d7e718b84edfcc1079e00e84a46a4cfa
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T14:39:42Z
closes apache/airavata#16 the fixes were applied but PR was not closed, closing now
commit 87a5521016566d68f1a858e37098b4bb4dba357c
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T14:41:09Z
closes apache/airavata#17 the fixes were applied but PR was not closed, closing now
commit 908569b3feb91f18660a29a4bb02f88acfde1981
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T14:44:26Z
closes apache/airavata#20 we should avoid pushing git ignore to repo and let IDE's ignore these files, closing now
commit 6368b161f34fb2d8ad7daf3014c13b5e4618b2b5
Author: Suresh Marru <sm...@apache.org>
Date: 2016-10-26T15:31:39Z
closes apache/airavata#28
commit e429faafa7af94b6f00369e83462750a0179330b
Author: scnakandala <su...@gmail.com>
Date: 2016-12-05T21:24:46Z
removing security check for getAllNotifications
commit 53b52dcf1dd1049280c6155ae16ddbccb41e04d2
Author: Marcus Christie <ma...@iu.edu>
Date: 2016-12-16T17:29:50Z
AIRAVATA-2282 notification sort: Prevent int overflow
Instead of returning the difference as a long and casting to an int,
which risks integer overflow, just return 1 or -1 corresponding to the
sign of the difference.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #89: AIRAVATA-2282 notification sort: Prevent int overflow
Posted by machristie <gi...@git.apache.org>.
Github user machristie commented on the issue:
https://github.com/apache/airavata/pull/89
@scnakandala can you review this when you get a chance? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata pull request #89: AIRAVATA-2282 notification sort: Prevent int over...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/airavata/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---