You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "vbarua (via GitHub)" <gi...@apache.org> on 2024/12/20 21:13:47 UTC

[I] [substrait] more abstract SubstraitConsumer API [datafusion]

vbarua opened a new issue, #13863:
URL: https://github.com/apache/datafusion/issues/13863

   ### Is your feature request related to a problem or challenge?
   
   The code in https://github.com/apache/datafusion/pull/13803 adds a `SubstraitConsumer` trait that explicitly includes the following methods
   ```rust
       fn get_extensions(&self) -> &Extensions;
       fn get_function_registry(&self) -> &impl FunctionRegistry;
   ```
   these methods are used by implementors to retrieve structs, which they can then use to resolve and map functions from Substrait into DataFusion.
   
   IMO, these structs are internal implementations detail and should be replace by dedicated methods that do not leak these details.
   
   ### Describe the solution you'd like
   
   Identify / devise a series of API methods for the SubstraitConsumer that can be used to replace the calls to `get_extensions` and `get_function_registry`.
   
   This may require rethinking how functions are mapped from Substrait to DataFusion
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org