You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/14 04:12:52 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33972: [SPARK-36734][SQL][BUILD][3.1] Upgrade ORC to 1.5.13

dongjoon-hyun commented on a change in pull request #33972:
URL: https://github.com/apache/spark/pull/33972#discussion_r707894517



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -693,11 +693,11 @@ class FileBasedDataSourceSuite extends QueryTest
   }
 
   test("SPARK-22790,SPARK-27668: spark.sql.sources.compressionFactor takes effect") {
-    Seq(1.0, 0.5).foreach { compressionFactor =>
+    Seq(1.0, 0.4).foreach { compressionFactor =>

Review comment:
       https://issues.apache.org/jira/browse/ORC-984 starts to add a metadata about a ORC writer version name. That increases a few byte per file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org