You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/09 21:32:41 UTC
[jira] [Commented] (QPID-3639) Refactored the APIs for
Qpid::Messaging::Session and modified the documentation.
[ https://issues.apache.org/jira/browse/QPID-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166535#comment-13166535 ]
jiraposter@reviews.apache.org commented on QPID-3639:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2978/
-----------------------------------------------------------
(Updated 2011-12-09 20:31:46.385562)
Review request for Andrew Stitcher, Gordon Sim and Ted Ross.
Changes
-------
Added a block to Session.next_receiver to optional process Receivers that way.
Summary
-------
Cleans up and makes the APIs more Ruby-like. Added better RDoc documentation to the APIs.
This addresses bug QPID-3639.
https://issues.apache.org/jira/browse/QPID-3639
Diffs (updated)
-----
trunk/qpid/cpp/bindings/qpid/ruby/test/test_receiver.rb 1208094
trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094
trunk/qpid/cpp/bindings/qpid/ruby/test/test_session.rb 1208094
trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/connection.rb 1208094
trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/receiver.rb 1208094
trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094
trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094
Diff: https://reviews.apache.org/r/2978/diff
Testing
-------
Thanks,
Darryl
> Refactored the APIs for Qpid::Messaging::Session and modified the documentation.
> --------------------------------------------------------------------------------
>
> Key: QPID-3639
> URL: https://issues.apache.org/jira/browse/QPID-3639
> Project: Qpid
> Issue Type: Improvement
> Components: Ruby Client
> Reporter: Darryl L. Pierce
> Attachments: 0001-Updated-Receiver-in-Ruby-to-take-a-Session-as-a-cons.patch, 0002-Updated-Sender-in-Ruby-to-take-a-Session-as-a-constr.patch, 0003-Updated-Session-in-Ruby-to-take-the-Connection-as-a-.patch, 0004-Refactored-the-APIs-for-the-Ruby-Session-bindings.patch, 0005-Updated-the-RDocs-for-Qpid-Messaging-Session.patch
>
>
> Several improvements to the Ruby code for a Session to make it more consistent as well as to fix excessive object creation.
> Also fixed the documentation so that the generated help files are more useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org