You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "u-ways (via GitHub)" <gi...@apache.org> on 2023/01/22 09:35:52 UTC

[GitHub] [logging-log4j-kotlin] u-ways opened a new pull request, #27: Upgrade kotlin and log4j versions

u-ways opened a new pull request, #27:
URL: https://github.com/apache/logging-log4j-kotlin/pull/27

   Hello,
   
   It seems that the Log4j version of the Kotlin API is out of date.
   On top of that, the Kotlin version hasn't been updated for the past 2 years.
   
   I have did a code analysis scan and found no incompatibles, tests are passing, and everything seems to be working as excepted.  
   
   ### Reasons to upgrade to 1.8.0 that are relevant: 
   
   - 1.8.0 - [Improved kotlin-reflect performance](https://kotlinlang.org/docs/whatsnew18.html#improved-kotlin-reflect-performance)
   - 1.6.0 - [Further Improvements to type inference for recursive generic types](https://kotlinlang.org/docs/whatsnew16.html#improved-type-inference-for-recursive-generic-types)
   - 1.5.30 - [Improvements to type inference for recursive generic types](https://kotlinlang.org/docs/whatsnew1530.html#improvements-to-type-inference-for-recursive-generic-types)
   - 1.5.0 - [Inline classes are released as Stable](https://kotlinlang.org/docs/whatsnew15.html#kotlin-jvm)
   
   And lots of other performance improvements overall... 
   
   ### Changes
   
   - Upgrade log4j to 2.19.0
   - Upgrade Kotlin to 1.8.0
   - kotlinx.coroutines to 1.6.4
   
   Feel free to amend as needed. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4j-kotlin] u-ways commented on pull request #27: Upgrade kotlin and log4j versions

Posted by "u-ways (via GitHub)" <gi...@apache.org>.
u-ways commented on PR #27:
URL: https://github.com/apache/logging-log4j-kotlin/pull/27#issuecomment-1402925352

   I see, that makes sense, thanks for letting me know, I am closing this one and opening a more appropriate PR for Log4j upgrade only. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4j-kotlin] jvz commented on pull request #27: Upgrade kotlin and log4j versions

Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on PR #27:
URL: https://github.com/apache/logging-log4j-kotlin/pull/27#issuecomment-1399623042

   The Kotlin API is a minimum version requirement. I've been using this library with Kotlin 1.4.x, 1.7.x, and 1.8.x. The Log4j version update is good, though!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4j-kotlin] u-ways closed pull request #27: Upgrade kotlin and log4j versions

Posted by "u-ways (via GitHub)" <gi...@apache.org>.
u-ways closed pull request #27: Upgrade kotlin and log4j versions
URL: https://github.com/apache/logging-log4j-kotlin/pull/27


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4j-kotlin] u-ways commented on pull request #27: Upgrade kotlin and log4j versions

Posted by "u-ways (via GitHub)" <gi...@apache.org>.
u-ways commented on PR #27:
URL: https://github.com/apache/logging-log4j-kotlin/pull/27#issuecomment-1399441247

   @jvz Can you have a look please? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org