You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/28 09:48:31 UTC
[GitHub] [iotdb] liuminghui233 opened a new pull request #4648: [To rel/0.12] [IOTDB-2219] Bug fix: query in-memory data is incorrect in cluster mode
liuminghui233 opened a new pull request #4648:
URL: https://github.com/apache/iotdb/pull/4648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4648: [To rel/0.12] [IOTDB-2219] Bug fix: query in-memory data is incorrect in cluster mode
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4648:
URL: https://github.com/apache/iotdb/pull/4648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] liuminghui233 commented on pull request #4648: [To rel/0.12] [IOTDB-2219] Bug fix: query in-memory data is incorrect in cluster mode
Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on pull request #4648:
URL: https://github.com/apache/iotdb/pull/4648#issuecomment-1002067091
> Could you please explain why? if remove the code here, will the single node not benefit from the cache? and the `cachedQueryDataSourcesMap` attribute seems do not used anywhere.
In [IOTDB-2101](https://issues.apache.org/jira/browse/IOTDB-2101), we refactor the construction process of `QueryDataSource`. We let all sensors in one virtual sg share the same `QueryDataSource` to save memory.
In the standalone mode, we will call the `initQueryDataSource()` method to construct all the required `QueryDataSource` in this query and save it in `cachedQueryDataSourcesMap`.
But in the cluster mode, for some reason, we must construct a `QueryDataSource` for each series.
I will post more details about the construction and use of `QueryDataSource` to a confluence page later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org