You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/03/26 00:58:57 UTC
[kudu-CR] docs: Move documentation style guide from user guide to design-docs
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6490
Change subject: docs: Move documentation style guide from user guide to design-docs
......................................................................
docs: Move documentation style guide from user guide to design-docs
This isn't very important to the typical end-user and doesn't really
belong in the user guide. Let's move the way it's primarily viewed from
the web site to the git repo and link people to the GitHub rendering of
the doc from the contributing page of the user guide.
Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
---
M docs/contributing.adoc
M docs/design-docs/README.md
R docs/design-docs/doc-style-guide.adoc
3 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/6490/1
--
To view, visit http://gerrit.cloudera.org:8080/6490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Move documentation style guide from user guide to design-docs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: docs: Move documentation style guide from user guide to design-docs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] docs: Move documentation style guide from user guide to design-docs
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6490
to look at the new patch set (#2).
Change subject: docs: Move documentation style guide from user guide to design-docs
......................................................................
docs: Move documentation style guide from user guide to design-docs
This isn't very important to the typical end-user and doesn't really
belong in the user guide. Let's move the way it's primarily viewed from
the web site to the git repo and link people to the GitHub rendering of
the doc from the contributing page of the user guide.
Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
---
M docs/contributing.adoc
M docs/design-docs/README.md
R docs/design-docs/doc-style-guide.adoc
M docs/support/jekyll-templates/document.html.erb
4 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/6490/2
--
To view, visit http://gerrit.cloudera.org:8080/6490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: Move documentation style guide from user guide to design-docs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: Move documentation style guide from user guide to design-docs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: Move documentation style guide from user guide to design-docs
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: docs: Move documentation style guide from user guide to design-docs
......................................................................
Patch Set 2: Verified+1
Overriding ITClient test failure
--
To view, visit http://gerrit.cloudera.org:8080/6490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: Move documentation style guide from user guide to design-docs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.
Change subject: docs: Move documentation style guide from user guide to design-docs
......................................................................
docs: Move documentation style guide from user guide to design-docs
This isn't very important to the typical end-user and doesn't really
belong in the user guide. Let's move the way it's primarily viewed from
the web site to the git repo and link people to the GitHub rendering of
the doc from the contributing page of the user guide.
Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Reviewed-on: http://gerrit.cloudera.org:8080/6490
Tested-by: Mike Percy <mp...@apache.org>
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M docs/contributing.adoc
M docs/design-docs/README.md
R docs/design-docs/doc-style-guide.adoc
M docs/support/jekyll-templates/document.html.erb
4 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Mike Percy: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9caa8767e2b3dd26cac11157b80a0b452d830c4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>