[jira] [Comment Edited] (FLINK-37889) Add new FlinkJoinToFlinkMultiJoinRule rule

["Gustavo de Morais (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-37889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979902#comment-17979902 ] 

Gustavo de Morais edited comment on FLINK-37889 at 6/17/25 1:35 PM:
--------------------------------------------------------------------

Hey [~stevenpoor], to be able to make the timeline, I couldn't wait longer and I had to get to this to have a working e2e version: [https://github.com/apache/flink/pull/26687.] I have a simpler version for now, feel free to take a look.

It doesn't cover FLINK-37890, so it doesn't have logic to check for a commonJoinKey and create multiple multi joins if there is no commonJoinKey for a chain of joins. If you want to contribute that part of your code, let us know.


was (Author: JIRAUSER307895):
Hey [~stevenpoor], to be able to make the timeline, I couldn't wait longer and I had to get to this to have a working e2e version: [https://github.com/apache/flink/pull/26687.] I have a simpler version for now, feel free to take a look.

> Add new FlinkJoinToFlinkMultiJoinRule rule
> ------------------------------------------
>
>                 Key: FLINK-37889
>                 URL: https://issues.apache.org/jira/browse/FLINK-37889
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Gustavo de Morais
>            Priority: Major
>
> The current FlinkJoinToMultiJoinRule is implemented and only used for join reordering. We can use it as a base but we need a new set of optimizer rules for the multi way join operator. This ticket covers:
>  * Add FlinkLogicalMultiJoin with all parameters we need to create it
>  ** There are some parameters that calcite's MultiJoin does not contain as we require it. For example: we only have outerJoinConditions and we actually need all join conditions for each input level, including inner joins.
> Related:
>  * Add right join to left join rule - our operator only works with left joins
>  * Check if the join chain respects the multi join common key restrictions
>  ** If not, create one multi join for each group of joins that respect. That means 9 chained joins, 3 have one common key and 6 have another will generate two chained multi joins.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)