You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/26 07:56:02 UTC

[jira] Created: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

refactor linux specific code in luni/OSNetworkSystem.c
------------------------------------------------------

         Key: HARMONY-413
         URL: http://issues.apache.org/jira/browse/HARMONY-413
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Minor


There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-413?page=all ]

Mark Hindess updated HARMONY-413:
---------------------------------

    Attachment: refactor.linux.specific.code.from.osnetworksystem.c.diff

This patch moves the linux specific code and makes a few other modifications to merge some of the differences between win.IA32/luni/OSNetworkSystem.c.

I'll submit a further patch later - when I've finished testing it - for the move of linux.IA32/luni/OSNetworkSystem.c to the shared tree.


> refactor linux specific code in luni/OSNetworkSystem.c
> ------------------------------------------------------
>
>          Key: HARMONY-413
>          URL: http://issues.apache.org/jira/browse/HARMONY-413
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: refactor.linux.specific.code.from.osnetworksystem.c.diff
>
> There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-413?page=all ]

Tim Ellison reassigned HARMONY-413:
-----------------------------------

    Assign To: Tim Ellison

> refactor linux specific code in luni/OSNetworkSystem.c
> ------------------------------------------------------
>
>          Key: HARMONY-413
>          URL: http://issues.apache.org/jira/browse/HARMONY-413
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: 01.make.luni.osnetworksystem.c.shared.sh, 02.make.luni.osnetworksystem.c.shared.diff, refactor.linux.specific.code.from.osnetworksystem.c.diff
>
> There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-413?page=all ]

Mark Hindess updated HARMONY-413:
---------------------------------

    Attachment: 01.make.luni.osnetworksystem.c.shared.sh
                02.make.luni.osnetworksystem.c.shared.diff

This script and diff move OSNetworkSystem.c to the native-src/shared/luni tree (using the copy refactored in the refactor.*.diff from the linux tree.)

The refactor.diff should be applied first.  In fact, those changes will also need to be checked in before the "svn move" in 01.sh will work.



> refactor linux specific code in luni/OSNetworkSystem.c
> ------------------------------------------------------
>
>          Key: HARMONY-413
>          URL: http://issues.apache.org/jira/browse/HARMONY-413
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: 01.make.luni.osnetworksystem.c.shared.sh, 02.make.luni.osnetworksystem.c.shared.diff, refactor.linux.specific.code.from.osnetworksystem.c.diff
>
> There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-413?page=all ]
     
Tim Ellison resolved HARMONY-413:
---------------------------------

    Resolution: Fixed

Thanks Mark,

Various patches/moves etc. applied to native-src at repo revision 399328.

Please check that the problem was resolved as you expected.


> refactor linux specific code in luni/OSNetworkSystem.c
> ------------------------------------------------------
>
>          Key: HARMONY-413
>          URL: http://issues.apache.org/jira/browse/HARMONY-413
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: 01.make.luni.osnetworksystem.c.shared.sh, 02.make.luni.osnetworksystem.c.shared.diff, refactor.linux.specific.code.from.osnetworksystem.c.diff
>
> There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-413?page=all ]
     
Tim Ellison closed HARMONY-413:
-------------------------------


Verified by Mark


> refactor linux specific code in luni/OSNetworkSystem.c
> ------------------------------------------------------
>
>          Key: HARMONY-413
>          URL: http://issues.apache.org/jira/browse/HARMONY-413
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: 01.make.luni.osnetworksystem.c.shared.sh, 02.make.luni.osnetworksystem.c.shared.diff, refactor.linux.specific.code.from.osnetworksystem.c.diff
>
> There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-413) refactor linux specific code in luni/OSNetworkSystem.c

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-413?page=comments#action_12377988 ] 

Mark Hindess commented on HARMONY-413:
--------------------------------------

Looks good.  Thanks Tim.

> refactor linux specific code in luni/OSNetworkSystem.c
> ------------------------------------------------------
>
>          Key: HARMONY-413
>          URL: http://issues.apache.org/jira/browse/HARMONY-413
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: 01.make.luni.osnetworksystem.c.shared.sh, 02.make.luni.osnetworksystem.c.shared.diff, refactor.linux.specific.code.from.osnetworksystem.c.diff
>
> There is a little linux specific code in OSNetworkSystem.c that is linux specific it should be refactored to the OSNetworkSystemLinux.c file that was created by HARMONY-183.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira