[GitHub] [kafka] Hangleton commented on a diff in pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse

["Hangleton (via GitHub)" <gi...@apache.org>]

Hangleton commented on code in PR #13764:
URL: https://github.com/apache/kafka/pull/13764#discussion_r1205888922


##########
clients/src/main/resources/common/message/OffsetFetchRequest.json:
##########
@@ -51,8 +57,9 @@
         "about": "The group ID."},
       { "name": "Topics", "type": "[]OffsetFetchRequestTopics", "versions": "8+", "nullableVersions": "8+",
         "about": "Each topic we would like to fetch offsets for, or null to fetch offsets for all topics.", "fields": [
-        { "name": "Name", "type": "string", "versions": "8+", "entityType": "topicName",
+        { "name": "Name", "type": "string", "versions": "0-8", "ignorable": true, "entityType": "topicName",
           "about": "The topic name."},
+        { "name": "TopicId", "type": "uuid", "versions": "9+", "ignorable": true, "about": "The unique topic ID" },

Review Comment:
   nit: The `"about"` field could be on a new line.



##########
clients/src/main/resources/common/message/OffsetFetchRequest.json:
##########
@@ -33,11 +33,17 @@
   // Version 7 is adding the require stable flag.
   //
   // Version 8 is adding support for fetching offsets for multiple groups at a time
-  "validVersions": "0-8",
+  //
+  // Version 9 adds GenerationIdOrMemberEpoch, MemberId and TopicId fields (KIP-848).
+  "validVersions": "0-9",
   "flexibleVersions": "6+",
   "fields": [
     { "name": "GroupId", "type": "string", "versions": "0-7", "entityType": "groupId",
       "about": "The group to fetch offsets for." },
+    { "name": "GenerationIdOrMemberEpoch", "type": "int32", "versions": "9+", "default": "-1", "ignorable": true,

Review Comment:
   Do we want to add these fields in this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org