You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pdion891 <gi...@git.apache.org> on 2015/11/22 16:42:17 UTC
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
GitHub user pdion891 opened a pull request:
https://github.com/apache/cloudstack/pull/1103
update release to 4.7.0 so it use proper packages and systemvm
This update container creation of master branch to 4.7.0 version.
It doesn't fix the /dev/loop0 issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdion891/cloudstack dockerfile4.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1103
----
commit c94b2da9a89ab681705a7fb700f02b7d8d98ede1
Author: Pierre-Luc Dion <pd...@apache.org>
Date: 2015-11-22T15:40:12Z
update release to 4.7.0 so it use proper packages and systemvm
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-158779047
@remibergsma you are right, we don't need to up the sysvm template version yet. For other version numbers mentioned, @pdion891 can you add thos location in the build_asf.sh and setnextversion.sh scripts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-175848696
Thanks for the reminder Rohit. I will update this PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-159179258
@pdion891 @bhaisaab In about two weeks (Dec 7) we freeze for 4.7.0. That would be a nice time to look back and see if the systemvm template needs to be bumped or not. Right now, there is no PR merged yet that requires a new version, so I don't want to bump it now. It's just too damn annoying upgrading all systemvms if there is no reason. Once there is, we will bump it of course.
Let me add it to the release procedure, to check at freeze time whether the systemvm version needs to be bumped. We will most likely have releases coming where we don't need to bump the version.
Also @pdion891 could you please squash the commits. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-159133510
I have updated release scripts as per @DaanHoogland comments but didn't change template version, based on @bhaisaab I would suspect we will upgrade sysvm on 4.7, soon ?
Thanks @DaanHoogland for the location of those scripts, I was wondering how to automate this version changes! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-158776432
Thanks @pdion891! I agree with all of them, except the systemvm template. There is no reason to bump that version because there is no change yet. As soon as we introduce a change that is not compatible with 4.6.0 template, we should bump the version. Until that happens, I'd like to be able to have 4.7.0 to use the same template as 4.6.0.
In the future we should get a separate systemvm version numbering schema (separate repo even?), to break with the "new cloudstack version == new systemvm version". Upgrades are much easier / less impacting if one does not need to recreate all sytemvms (1000+ in our case). Especially when we're releasing more often.
Pinging @DaanHoogland @bhaisaab to see what they think and if I maybe forget something? Can we keep the version of systemvms at 4.6.0 until something changes? If not, can we make it work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-158777294
@pdion891 See comments on https://issues.apache.org/jira/browse/CLOUDSTACK-9077 for possible solution for `/dev/loop0` issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-160331954
@pdion891 I'm OK with this, but I think you do not need to change the version in `tools/docker/systemtpl.sh` until there is a 4.7 version. Otherwise it will result in a 4.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 closed the pull request at:
https://github.com/apache/cloudstack/pull/1103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-194620295
replaced by #1435
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-158895870
@bhaisaab Sure, that would be a good reason. But it's not ready so let's bump when we merge that PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-166814374
@pdion891 LGTM, but you'll need to fix the version again for master/4.8 and squash the commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-158873719
@remibergsma I think we will need to create new systemvmtemplate for 4.7.0 if we'll get the openswan->strongswan patch merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1103#issuecomment-175681455
@pdion891 please rebase against latest and squash commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---