You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/01/20 23:46:27 UTC
[GitHub] [parquet-mr] wangyum opened a new pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
wangyum opened a new pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum commented on pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857#issuecomment-764048376
Sorry, this document outdate: http://mail-archives.apache.org/mod_mbox/parquet-dev/201906.mbox/%3CJIRA.13233926.1558083819000.446944.1560276180713@Atlassian.JIRA%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum commented on pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857#issuecomment-767180694
@bbraams I read a outdate document: http://mail-archives.apache.org/mod_mbox/parquet-dev/201906.mbox/%3CJIRA.13233926.1558083819000.446944.1560276180713@Atlassian.JIRA%3E
Both read and write are false:
```
### Documentation
The feature is feature flagged and is disabled by default. Both writing out checksums and
verifying them on the read path can be turned on individually, via the following two new config
flags:
* `parquet.page.write-checksum.enabled` (default: false)
* `parquet.page.verify-checksum.enabled` (default: false)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum commented on pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857#issuecomment-767180694
@bbraams I read a outdate document: http://mail-archives.apache.org/mod_mbox/parquet-dev/201906.mbox/%3CJIRA.13233926.1558083819000.446944.1560276180713@Atlassian.JIRA%3E
Both read and write are false:
```
### Documentation
The feature is feature flagged and is disabled by default. Both writing out checksums and
verifying them on the read path can be turned on individually, via the following two new config
flags:
* `parquet.page.write-checksum.enabled` (default: false)
* `parquet.page.verify-checksum.enabled` (default: false)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum closed pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum closed pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum commented on pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #857:
URL: https://github.com/apache/parquet-mr/pull/857#issuecomment-764048376
Sorry, this document outdate: http://mail-archives.apache.org/mod_mbox/parquet-dev/201906.mbox/%3CJIRA.13233926.1558083819000.446944.1560276180713@Atlassian.JIRA%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org