You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cjpearson <gi...@git.apache.org> on 2016/07/01 00:37:11 UTC
[GitHub] cordova-ios pull request #233: CB-9371, CB-9703: Fix how prepare handles ori...
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/233
CB-9371, CB-9703: Fix how prepare handles orientation on ios
Relates to https://github.com/apache/cordova-lib/pull/260
This changes the behavior of the default orientation preference to match the default orientation settings for new native iOS projects.
It also no longer modifies the orientation settings if the user does not specify an orientation preference.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-ios CB-9371
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #233
----
commit 55b0a26fb2ba4186273d98fb3adcee205b2fb632
Author: Connor Pearson <cj...@gmail.com>
Date: 2016-07-01T00:27:12Z
CB-9371: Fix how prepare handles orientation on ios
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #233: CB-9371, CB-9703: Fix how prepare handles ori...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #233: CB-9371, CB-9703: Fix how prepare handles orientatio...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/233
Confirmed that Xcode uses the new defaults. Pulling this in and testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #233: CB-9371, CB-9703: Fix how prepare handles orientatio...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/233
## [Current coverage][cc-pull] is **51.81%**
> Merging [#233][cc-pull] into [master][cc-base-branch] will not change coverage
```diff
@@ master #233 diff @@
==========================================
Files 11 11
Lines 882 882
Methods 132 132
Messages 0 0
Branches 143 143
==========================================
Hits 457 457
Misses 425 425
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [3d80c24...4d792db][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-ios/compare/3d80c24a594b4d43a368fa278a23218a3f17310f...4d792dba84a23866b2ab1850e49a921bacf82ba0
[cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/233?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org