You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/03 02:15:04 UTC

[GitHub] [spark] LantaoJin edited a comment on issue #26711: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

LantaoJin edited a comment on issue #26711: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN
URL: https://github.com/apache/spark/pull/26711#issuecomment-560966867
 
 
   > This is actually writing temp shuffle files into YARN container local dirs instead of local dirs? Could there be any performance difference after this PR? (Sorry I'm not familiar with YARN)
   
   Yes. I think only this part could have performance difference in YARN mode:
   https://github.com/apache/spark/pull/26711/files#diff-b25a153e05a044779df448f024c3a3afR125
   But this part already had potentially performance problem. See
   https://github.com/apache/spark/blob/4021354b73dd86ee765f50ff90ab777edfc21bdb/core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala#L215

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org