[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3046: [Feature][Connector-V2][Iceberg]Modify the scope of flink-shaded-hadoop-2 to provided to be compatible with hadoop3.x

[GitBox <gi...@apache.org>]

CalvinKirs commented on code in PR #3046:
URL: https://github.com/apache/incubator-seatunnel/pull/3046#discussion_r993287162


##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-iceberg-flink-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
             <version>${project.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-shaded-hadoop-2</artifactId>
+            <scope>test</scope>
+            <exclusions>
+                <exclusion>
+                    <groupId>org.apache.avro</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>

Review Comment:
   What is the reason for excluding here? If there will be conflicts, it is better that we provide the corresponding shade jar, otherwise this may hide the problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org