You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Cazen <gi...@git.apache.org> on 2016/05/08 05:56:54 UTC
[GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
GitHub user Cazen opened a pull request:
https://github.com/apache/incubator-quarks/pull/109
[QUARKS-166] Add Gate plumbing
Hmm The sample code in QUARKS-166 looks clearly. I just added test case.
Any advice would be appreciated :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Cazen/incubator-quarks QUARKS-166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit b41664db2b561e101b16211a063e74f7671475c2
Author: cazen.lee <ca...@samsung.com>
Date: 2016-05-08T05:47:32Z
Add Gate plumbing
commit f38780ce2bedb6296cf8643be169c43f0b3a5d25
Author: cazen.lee <ca...@samsung.com>
Date: 2016-05-08T05:48:56Z
Add testcase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen closed the pull request at:
https://github.com/apache/incubator-quarks/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/109#discussion_r62502145
--- Diff: api/topology/src/test/java/quarks/test/topology/PlumbingTest.java ---
@@ -601,4 +602,66 @@ public void testParallel() throws Exception {
// actDuration < 0.5 * expMinSerialDuration);
// }
-}
+ @Test
+ public void testGate() throws Exception {
+ // Timing variances on shared machines can cause this test to fail
--- End diff --
Does this "timing variances" failure condition actually happen? I can't imagine how it could. Same with 2nd test case (though may have to increase test-tmo beyone 1sec. for that one).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Posted by Cazen <gi...@git.apache.org>.
GitHub user Cazen reopened a pull request:
https://github.com/apache/incubator-quarks/pull/109
[QUARKS-166] Add Gate plumbing
Hmm The sample code in QUARKS-166 looks clearly. I just added test case.
Any advice would be appreciated :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Cazen/incubator-quarks QUARKS-166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit b41664db2b561e101b16211a063e74f7671475c2
Author: cazen.lee <ca...@samsung.com>
Date: 2016-05-08T05:47:32Z
Add Gate plumbing
commit f38780ce2bedb6296cf8643be169c43f0b3a5d25
Author: cazen.lee <ca...@samsung.com>
Date: 2016-05-08T05:48:56Z
Add testcase
commit 8389ad73cbea27670e4e9ade96a56ed24236decb
Author: Cazen Lee <ca...@korea.com>
Date: 2016-05-09T14:29:34Z
remove condition check for timing variances failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/109#discussion_r62506139
--- Diff: api/topology/src/test/java/quarks/test/topology/PlumbingTest.java ---
@@ -601,4 +602,66 @@ public void testParallel() throws Exception {
// actDuration < 0.5 * expMinSerialDuration);
// }
-}
+ @Test
+ public void testGate() throws Exception {
+ // Timing variances on shared machines can cause this test to fail
--- End diff --
Hi @dlaboss
Sorry for that. At first time I was planning to make test with PlumbingStreams.blockingDelay (similar to the testBlockingDelay) However, plans changed but the line did not erased.
I will erase immediately "assumeTrue" line in two Testcase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---